-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-2317: Add motion service code snippets #3970
DOCS-2317: Add motion service code snippets #3970
Conversation
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I would like the last comment I left addressed but I'm going to approve it in advance. Thanks for being thorough with this!
services/motion/motion.go
Outdated
// geometriesInFrame := []*referenceframe.GeometriesInFrame{} | ||
// | ||
// worldState, _ := referenceframe.NewWorldState(geometriesInFrame, nil) | ||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you aren't making a worldState you can delete these and just pass nil
into the Move function. If you want to include a worldstate then you should add geometries to it. I'm not sure if the motivation of these docs is to include a minimal example or an example utilizing all the fields
Thanks for all of the help with these! I see your comment and will definitely address it before merging. I appreciate your reviews! |
f37c1b9
to
e104461
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Thanks much for your thorough eye and careful checking!
These code snippets were tested on a machine configured with real hardware Monday, 5/20. The purpose was to validate the functionality of these samples with the motion and SLAM services.
This error was thrown every time we tested the script. This error came up regardless of the method being called or the success of the method.