[RSDK-9149] Fix Logger Test Fails #4723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
cheukt
reviewed
Jan 21, 2025
robot/web/options/options.go
Outdated
| @@ -73,6 +73,8 @@ type Options struct { | |||
| WebRTCOnPeerRemoved func(pc *webrtc.PeerConnection) | |||
|
|
|||
| DisableMulticastDNS bool | |||
|
|
|||
| WaitForHandlers bool | |||
There was a problem hiding this comment.
add a comment explaining what this comment does
viambot
added
safe to test
viambot
added
the
safe to test
viambot
added
safe to test
This reverts commit 9d3ea91.
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
bashar-515
changed the title
bashar-515
commented
Jan 21, 2025
There was a problem hiding this comment.
I completely removed the two failing test bc it didn't seem right to assign a seemingly arbitrary number as the expected number of logs. Plus, the number varies by platform. So, I think it's better for the tests to not be included to say that we do now expect some number of error logs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is causing some RDK tests to fail due to a) unexpected - unexpected by the tests, expected by us - log messages showing up and b) a data race (likely due to a message being logged in a go routine caused by a test that has already completed/returned). This PR fixes those failures by allowing for the graceful stopping of the web servers used in the tests that are failing.