Add generic and gripper FromDependencies methods
#4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
JohnN193
approved these changes
Jan 27, 2025
JohnN193
reviewed
Jan 27, 2025
| func FromDependencies(deps resource.Dependencies, name string) (Gripper, error) { | ||
| return resource.FromDependencies[Gripper](deps, Named(name)) | ||
| } | ||
|
|
||
| // NamesFromRobot is a helper for getting all gripper names from the given Robot. | ||
| func NamesFromRobot(r robot.Robot) []string { |
There was a problem hiding this comment.
ngl didn't know this was a method on some of the apis either
There was a problem hiding this comment.
makes sense - none of the services have this so it's a components-only helper ™️
There was a problem hiding this comment.
plus you joined components after we added all this noise.
randhid
commented
Jan 27, 2025
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added gripper as it was missing.
Added generic to fit the pattern.