[RSDK-5823] remove Board.model_attributes() from the SDK #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
penguinland
added a commit
that referenced
this pull request
Dec 8, 2023
This should have been removed in #491, but I forgot. It's dead code. Grepping the codebase for `Attributes` turns up only 1 result (in src/viam/errors.py), and that's a false positive. Linking things up: I noticed this while reviewing viamrobotics/docs#2313
njooma
pushed a commit
that referenced
this pull request
Dec 22, 2023
This should have been removed in #491, but I forgot. It's dead code. Grepping the codebase for `Attributes` turns up only 1 result (in src/viam/errors.py), and that's a false positive. Linking things up: I noticed this while reviewing viamrobotics/docs#2313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed from the RDK in viamrobotics/rdk#3253. From the perspective of the Python SDK, no information is being communicated with this function: it always says that the board is remote and nothing else.
Strictly speaking, this is a breaking change because we don't know who out in the world is using this function. but my understanding is that the entire SDK is still in beta so breaking changes are okay. and anyone using it isn't getting any utility out of it, as previously stated.