Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add scroll on autocomplete #1448

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Feat: Add scroll on autocomplete #1448

merged 5 commits into from
Aug 1, 2024

Conversation

ArthurTriis1
Copy link
Collaborator

@ArthurTriis1 ArthurTriis1 commented Jul 23, 2024 •
edited
Loading

What is the purpose of this pull request?

Add a maxHeight property con Autocompleteinput

Screenshots or example usage

Jul-23-2024 19-09-38

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vercel Vercel
Copy link

vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
styleguide ❌ Failed (Inspect) Jul 31, 2024 0:46am

@ArthurTriis1 ArthurTriis1 self-assigned this Jul 23, 2024
@ArthurTriis1 ArthurTriis1 requested a review from a team July 24, 2024 17:50
ataideverton
ataideverton reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ataideverton ataideverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test using this prop on the UnitTests?

@ArthurTriis1 ArthurTriis1 force-pushed the feat/add-scrol-on-autocomplete branch from 13201b2 to 484d49a Compare July 31, 2024 12:46
@ArthurTriis1 ArthurTriis1 merged commit 47bdbf7 into master Aug 1, 2024
1 of 3 checks passed
@ArthurTriis1 ArthurTriis1 deleted the feat/add-scrol-on-autocomplete branch August 1, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ataideverton ataideverton ataideverton approved these changes

@matheusps matheusps Awaiting requested review from matheusps

@lucasaarcoverde lucasaarcoverde Awaiting requested review from lucasaarcoverde

Assignees

@ArthurTriis1 ArthurTriis1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArthurTriis1 @ataideverton