Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Quality of Life improvements #36

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Small Quality of Life improvements #36

merged 2 commits into from
Jul 11, 2024

Conversation

BigBlueHat
Copy link
Member

  • Remove unused imports from main.js.
  • Handle implementations list not being an Array.

@BigBlueHat BigBlueHat changed the title tweaks Small Quality of Life improvements May 2, 2024
aljones15
aljones15 reviewed May 31, 2024
View reviewed changes
lib/main.js Show resolved Hide resolved
aljones15
aljones15 reviewed May 31, 2024
View reviewed changes
lib/main.js Show resolved Hide resolved
aljones15
aljones15 approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but not sure we really need to get rid of exports now. I do like the check to make sure local is an array though.

implementations/index.js Show resolved Hide resolved
@BigBlueHat BigBlueHat merged commit 521de43 into main Jul 11, 2024
2 checks passed
@BigBlueHat BigBlueHat deleted the tweaks branch July 11, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljones15 aljones15 aljones15 approved these changes

@tminard tminard tminard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BigBlueHat @aljones15 @tminard