-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eksctl #374
base: main
Are you sure you want to change the base?
Add eksctl #374
Conversation
Hey, just wanted to let you know that I appreciate this and I'll be taking a look at it within the next week or so. I just spent a bunch of time on Webi PRs and updates a few weeks ago and I've needed to focus on some other projects for a bit to get caught up on them. :) |
title: eksctl | ||
homepage: https://github.com/weaveworks/eksctl | ||
tagline: | | ||
The official CLI for Amazon EKS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually endorsed by Amazon? I think you may mean "original" or "best", but I'm pretty sure this isn't the "official" CLI. That's written in Python and described here: https://docs.aws.amazon.com/cli/latest/reference/eks/index.html
Or am I missing something?
The official CLI for Amazon EKS | ||
--- | ||
|
||
To update or switch versions, run `webi example@stable` (or `@v2`, `@beta`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update example
text.
|
||
## Cheat Sheet | ||
|
||
> From the `eksctl` ReadMe: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReadMe should be stylized README.
``` | ||
|
||
### Add Baz Highlighting | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace examples sections with real examples for eksctl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've requested a few changes. Please see inline comments.
Also, please run the code formatting tools before committing:
webi prettier
webi shfmt
# npx prettier@2 -w '**/*.{js,md,html}'
npm run prettier
# shfmt -w -i 4 -sr -s ./
npm run shfmt
This looks really good. Thanks so much for contributing. I just have a few changes as seen above ^^. The main thing is that the docs need some fixing. I'd love to have more cheat sheet examples, if you could. I don't use EKS, but since you do, you probably know the most common things that people want to do, and it would be great if you could add more of those. That said, it's NOT a blocking issue. |
P.S. This is up on beta: https://beta.webinstall.dev/eksctl |
46e08e3
to
2b10263
Compare
bump @mlopez122 |
Is this issue already solved or not ? |
@navitux This was left half done. The Cheat Sheet still has stuff like Could you round that out? |
What's Left to Do?
OP's Message
Following the provided instruction video I added the eksctl functionality to webinstall. I had some trouble in that I had to edit the ps1 file because when downloading the actual eksctl app, it comes as a single .exe file.
Additionally, My native operating system is Windows, but I was using an Ubuntu install to configure the files. As a result, I kept encountering a weird occurrence where each newline was terminated with a ^M character inside of the bash script. This kept throwing errors inside of my Ubuntu client. After some troubleshooting, I found per this stack overflow post that the issue was that ^M is the carriage-return character in Windows, and it can interfere with Linux/Mac behavior. After removing the character from the bash script, the tests ran normally per the video's testing instructions.