Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ollama): classify 'rocm' as its own cpu #897

Merged
merged 3 commits into from
Sep 16, 2024
Merged

fix(ollama): classify 'rocm' as its own cpu #897

merged 3 commits into from
Sep 16, 2024

Conversation

coolaj86
Copy link
Member

@coolaj86 coolaj86 commented Sep 14, 2024 •
edited
Loading

jojobyte
jojobyte approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@jojobyte jojobyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Base automatically changed from ref-git to main September 15, 2024 22:08
@coolaj86 coolaj86 force-pushed the fix-ollama branch 5 times, most recently from aaf03e6 to efab495 Compare September 16, 2024 01:16
@coolaj86 coolaj86 force-pushed the fix-ollama branch 4 times, most recently from b622ac8 to 62fb353 Compare September 16, 2024 23:48
@coolaj86 coolaj86 merged commit b7a113a into main Sep 16, 2024
3 checks passed
@coolaj86 coolaj86 deleted the fix-ollama branch September 16, 2024 23:55
@coolaj86
Copy link
Member Author

Looks can be deceiving.

But after much trial and error (meaning manual testing), it's now confirmed working on Linux, macOS, and Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojobyte jojobyte jojobyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolaj86 @jojobyte