Add distinguishable state for cb and dictionary-like #1353

vmpstr · 2023-08-16T14:07:56Z

At least two implementers are interested (and none opposed):
- Chromium
- WebKit
Tests are written and can be reviewed and commented upon at:
- N/A
Implementation bugs are filed:
- Chromium: N/A
- Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1874665
- WebKit: https://bugs.webkit.org/show_bug.cgi?id=267533
- Deno: …
- Node.js: …
- webidl2.js: Add distinguishing between callback and dictionary-like types w3c/webidl2.js#768
- widlparser: Add distinguishing between callback and dictionary-like types plinss/widlparser#84
MDN issue is filed: N/A

(See WHATWG Working Mode: Changes for more details.)

index.bs

bathos · 2023-08-16T15:40:59Z

This comment only intends to make a design decision implied by this PR explicit to other readers.

The [LTNOAN] annotation causes only nullable types with the annotated callback function as their inner type to have the problematically expanded value space — and more specifically, only when used as an attribute’s type. In every other context, an [LTNOAN]-annotated callback function behaves exactly the same as any other.

This PR will leave all [LTNOAN]-annotated callback functions indistinguishable from dictionary-likes even in contexts where [LTNOAN] is otherwise ignored/meaningless.

That seems like a reasonable call:

It’s much simpler than trying to account for all those quirky conditions
It’s usually okay (or even desirable) to leave legacy features in the dust when introducing new features

Again, this comment’s just an “FYI” thing in case other folks do see a problem with this approach — as far as I can tell, it works.

jeremyroman

Makes sense to me (though my approval isn't significant).

jeremyroman · 2023-08-17T21:17:48Z

index.bs

+            [=union type=] selection, and the possible types are [=callback
+            function=] and disctionary-like category type, then the type is a
+            [=callback function=] if the object is [=ECMAScript/callable=].
+            Otherwise, it is a dictionary-like category type.


For clarity, even though this pull request doesn't change it, the overload resolution algorithm and algorithm "convert an ECMAScript value an to IDL union type" already handle this correctly in the Callable(V) case, as I understand it?

jeremyroman · 2023-08-17T21:22:39Z

index.bs

+        1.  A [=callback function=] that does not have
+            [{{LegacyTreatNonObjectAsNull}}] extended attribute is
+            distinguishable from a dictionary-like category object based on
+            whether the object is [=ECMAScript/callable=]. When selecting a


Suggested change

1. A [=callback function=] that does not have

[{{LegacyTreatNonObjectAsNull}}] extended attribute is

distinguishable from a dictionary-like category object based on

whether the object is [=ECMAScript/callable=]. When selecting a

1. A [=callback function=] that does not have

[{{LegacyTreatNonObjectAsNull}}] extended attribute is

distinguishable from a dictionary-like type. When selecting a

I think the second sentence clarifies that the Callable algorithm is used, but what's normatively important in this algorithm is that callback functions without LTNOAN are distinguishable from dictionary-like types. (Since this algorithm operates on WebIDL types rather than ECMAScript values, it cannot actually normatively use Callable here.) Separating them with a full stop makes that clearer to me.

As a nit, the normative sentence here should probably discuss the types rather than the objects, for the same reason.

I understand that the ECMAScript value is the ting that can be Callable, and it seems that at least the union resolution will convert a Callable ECMAScript value to a callable type. Otherwise, it will convert it to a dictionary-like type?

I'm not sure what you mean about a full stop separating things though.

There are no values in this algorithm, only types. So the normative text here should describe dictionary-like WebIDL types, not ECMAScript values (objects or otherwise) Consequently, this algorithm cannot depend on whether the value is [=ECMAScript/callable=] (though it could be noted informatively). The value conversion and overload resolution algorithms already do use [=ECMAScript/callable=] where appropriate.

By a full stop, I mean the punctuation mark, a period (.). I think the first sentence of this bullet point should be the normative text about how, given two WebIDL types, an implementation can tell whether they are distinguishable. Any notes about how that corresponds to value conversion and overload resolution can follow in a separate sentence or parenthetical, if necessary.

Ok, I've updated this to explicitly separate normative text from non-normative notes. I don't think a punctuation mark is sufficient to imply a switch from normative to non-normative text.

Let me know if this reads better

lgtm thanks

domenic

Looks good with a wording nit.

Can we get multi-implementer interest here somehow? In particular, making sure this doesn't break something deep in their binding system, for example.

If the API you intend to use this for has multi-implementer interest, then recruiting those people to come over here and say "yes, no problem with changing Web IDL to accommodate that API" would be perfect.

index.bs

Co-authored-by: Domenic Denicola <[email protected]>

This patch does several things: - Loosens the restriction in IDL checker to allow distinguishing between callback types and dictionary like types. This implements the following PR: whatwg/webidl#1353 - Uses the loosened restriction to add a behind-the-flag overload of startViewTransition that takes a dictionary - Adds a smoke test for the new syntax Bug: 1466251 Change-Id: I7b82b49e993e8ad907804d772b4f2c6e0f1ab3e8

yuki3 · 2023-10-27T05:45:30Z

Looks good with a wording nit.

Can we get multi-implementer interest here somehow? In particular, making sure this doesn't break something deep in their binding system, for example.

If the API you intend to use this for has multi-implementer interest, then recruiting those people to come over here and say "yes, no problem with changing Web IDL to accommodate that API" would be perfect.

FWIW, I've implemented the corresponding change in Chromium. It's already been landed.

This patch does several things: - Loosens the restriction in IDL checker to allow distinguishing between callback types and dictionary like types. This implements the following PR: whatwg/webidl#1353 - Uses the loosened restriction to add a behind-the-flag overload of startViewTransition that takes a dictionary - Adds a smoke test for the new syntax Bug: 1466251 Change-Id: I7b82b49e993e8ad907804d772b4f2c6e0f1ab3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4973315 Reviewed-by: Xianzhu Wang <[email protected]> Reviewed-by: David Bokan <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1216984}

lukewarlow · 2024-01-12T23:00:22Z

Fwiw I have an implementation of this change within WebKit and it's rather trivial. @keithamus will probably be the one who ends up actually upstreaming it (he's prototyping observerables). Idk what signal is needed here for implementer interest, potentially can just wait and mark this as 2 implementers once the code is merged upstream?

https://github.com/WebKit/WebKit/compare/lukewarlow:callback-dictionary-union - a minimal branch with the changes required

In case anyone looks and wonders about the attribute special casing, WebKit doesn't support that attribute so no need to check it.

annevk · 2024-01-15T10:26:17Z

@vmpstr would you be willing to file the implementation bugs for this and update OP afterwards?

keithamus · 2024-01-15T10:50:17Z

I have filed https://bugs.webkit.org/show_bug.cgi?id=267533 (WebKit) & https://bugzilla.mozilla.org/show_bug.cgi?id=1874665 (Gecko) as I intend to work on these.

annevk · 2024-01-15T12:20:07Z

That's great. We'll need bugs for the tooling-related projects as well though. Less worried about browsers as they will get here through downstream features.

vmpstr · 2024-01-29T21:06:02Z

Sorry for the late reply. I'm happy to file implementation bugs, but I don't know which tooling-related projects you mean. Is there a canonical list?

saschanaz · 2024-01-29T21:31:14Z

It's in the PR template, the last two ones specifically.

vmpstr · 2024-01-29T21:38:18Z

Ah thanks, I'll file issues and update here when I've done so

https://bugs.webkit.org/show_bug.cgi?id=276572 Reviewed by NOBODY (OOPS!). This implements the base `Observable` class, as well as the `subscribe` method. In addition this adds the `Subscriber` internal class allows Observables to be subscribed to, and some additional machinery such as `SubscribeOptions`, `SubscriptionObserver` and so on. This also includes a fix to IDL generation to correctly generate callback function + dictionary unions (whatwg/webidl#1353). This does not implement any of the prototype methods on Observable, (other than subscribe) such as `takeUntil`, `filter`, `finally` and so on. * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any.worker-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/IDLTypes.h: * Source/WebCore/bindings/js/JSDOMConvertUnion.h: * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (AreTypesDistinguishableForOverloadResolution): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.cpp: Added. (WebCore::JSTestCallbackWithFunctionOrDict::JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::~JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::handleEvent): (WebCore::JSTestCallbackWithFunctionOrDict::visitJSFunction): (WebCore::toJS): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.h: Added. (WebCore::toJS): * Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep: * Source/WebCore/bindings/scripts/test/TestCallbackOrDict.idl: Added. * Source/WebCore/dom/Observable.cpp: Added. (WebCore::Observable::create): (WebCore::Observable::subscribe): (WebCore::Observable::makeSubscriber): (WebCore::Observable::Observable): * Source/WebCore/dom/Observable.h: Added. * Source/WebCore/dom/Observable.idl: Added. * Source/WebCore/dom/SubscribeOptions.h: Added. * Source/WebCore/dom/SubscribeOptions.idl: Added. * Source/WebCore/dom/Subscriber.cpp: Added. (WebCore::Subscriber::create): (WebCore::Subscriber::Subscriber): (WebCore::Subscriber::next): (WebCore::Subscriber::error): (WebCore::Subscriber::complete): (WebCore::Subscriber::addTeardown): (WebCore::Subscriber::close): (WebCore::Subscriber::abort): (WebCore::Subscriber::closeAndTeardown): * Source/WebCore/dom/Subscriber.h: Added. * Source/WebCore/dom/Subscriber.idl: Added. * Source/WebCore/dom/SubscriberCallback.cpp: Added. * Source/WebCore/dom/SubscriberCallback.h: Added. * Source/WebCore/dom/SubscriberCallback.idl: Added. * Source/WebCore/dom/SubscriptionObserver.h: Added. * Source/WebCore/dom/SubscriptionObserver.idl: Added. * Source/WebCore/dom/SubscriptionObserverCallback.h: Added. * Source/WebCore/dom/SubscriptionObserverCallback.idl: Added.

https://bugs.webkit.org/show_bug.cgi?id=276572 Reviewed by NOBODY (OOPS!). This implements the base `Observable` class, as well as the `subscribe` method. In addition this adds the `Subscriber` internal class allows Observables to be subscribed to, and some additional machinery such as `SubscribeOptions`, `SubscriptionObserver` and so on. This also includes a fix to IDL generation to correctly generate callback function + dictionary unions (whatwg/webidl#1353). This does not implement any of the prototype methods on Observable, (other than subscribe) such as `takeUntil`, `filter`, `finally` and so on. * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any.worker-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/IDLTypes.h: * Source/WebCore/bindings/js/JSDOMConvertUnion.h: * Source/WebCore/bindings/js/JSSubscriberCustom.cpp: Added. (WebCore::JSSubscriber::visitAdditionalChildren): * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (AreTypesDistinguishableForOverloadResolution): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.cpp: Added. (WebCore::JSTestCallbackWithFunctionOrDict::JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::~JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::handleEvent): (WebCore::JSTestCallbackWithFunctionOrDict::visitJSFunction): (WebCore::toJS): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.h: Added. (WebCore::toJS): * Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep: * Source/WebCore/bindings/scripts/test/TestCallbackOrDict.idl: Added. * Source/WebCore/dom/Observable.cpp: Added. (WebCore::Observable::create): (WebCore::Observable::subscribe): (WebCore::Observable::makeSubscriber): (WebCore::Observable::Observable): * Source/WebCore/dom/Observable.h: Added. * Source/WebCore/dom/Observable.idl: Added. * Source/WebCore/dom/SubscribeOptions.h: Added. * Source/WebCore/dom/SubscribeOptions.idl: Added. * Source/WebCore/dom/Subscriber.cpp: Added. (WebCore::Subscriber::create): (WebCore::Subscriber::Subscriber): (WebCore::Subscriber::next): (WebCore::Subscriber::error): (WebCore::Subscriber::complete): (WebCore::Subscriber::addTeardown): (WebCore::Subscriber::close): (WebCore::Subscriber::abort): (WebCore::Subscriber::closeAndTeardown): * Source/WebCore/dom/Subscriber.h: Added. * Source/WebCore/dom/Subscriber.idl: Added. * Source/WebCore/dom/SubscriberCallback.cpp: Added. * Source/WebCore/dom/SubscriberCallback.h: Added. * Source/WebCore/dom/SubscriberCallback.idl: Added. * Source/WebCore/dom/SubscriptionObserver.h: Added. * Source/WebCore/dom/SubscriptionObserver.idl: Added. * Source/WebCore/dom/SubscriptionObserverCallback.h: Added. * Source/WebCore/dom/SubscriptionObserverCallback.idl: Added.

https://bugs.webkit.org/show_bug.cgi?id=276572 Reviewed by NOBODY (OOPS!). This implements the base `Observable` class, as well as the `subscribe` method. In addition this adds the `Subscriber` internal class allows Observables to be subscribed to, and some additional machinery such as `SubscribeOptions`, `SubscriptionObserver` and so on. This also includes a fix to IDL generation to correctly generate callback function + dictionary unions (whatwg/webidl#1353). This does not implement any of the prototype methods on Observable, (other than subscribe) such as `takeUntil`, `filter`, `finally` and so on. * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any.worker-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/IDLTypes.h: * Source/WebCore/bindings/js/JSDOMConvertUnion.h: * Source/WebCore/bindings/js/JSSubscriberCustom.cpp: Added. (WebCore::JSSubscriber::visitAdditionalChildren): * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (AreTypesDistinguishableForOverloadResolution): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.cpp: Added. (WebCore::JSTestCallbackWithFunctionOrDict::JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::~JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::handleEvent): (WebCore::JSTestCallbackWithFunctionOrDict::visitJSFunction): (WebCore::toJS): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.h: Added. (WebCore::toJS): * Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep: * Source/WebCore/bindings/scripts/test/TestCallbackOrDict.idl: Added. * Source/WebCore/dom/Observable.cpp: Added. (WebCore::Observable::create): (WebCore::Observable::subscribe): (WebCore::Observable::makeSubscriber): (WebCore::Observable::Observable): * Source/WebCore/dom/Observable.h: Added. * Source/WebCore/dom/Observable.idl: Added. * Source/WebCore/dom/SubscribeOptions.h: Added. * Source/WebCore/dom/SubscribeOptions.idl: Added. * Source/WebCore/dom/Subscriber.cpp: Added. (WebCore::Subscriber::create): (WebCore::Subscriber::Subscriber): (WebCore::Subscriber::next): (WebCore::Subscriber::error): (WebCore::Subscriber::complete): (WebCore::Subscriber::addTeardown): (WebCore::Subscriber::close): (WebCore::Subscriber::isInactiveDocument const): * Source/WebCore/dom/Subscriber.h: Added. * Source/WebCore/dom/Subscriber.idl: Added. * Source/WebCore/dom/SubscriberCallback.h: Added. * Source/WebCore/dom/SubscriberCallback.idl: Added. * Source/WebCore/dom/SubscriptionObserver.h: Added. * Source/WebCore/dom/SubscriptionObserver.idl: Added. * Source/WebCore/dom/SubscriptionObserverCallback.h: Added. * Source/WebCore/dom/SubscriptionObserverCallback.idl: Added.

https://bugs.webkit.org/show_bug.cgi?id=276572 Reviewed by NOBODY (OOPS!). This implements the base `Observable` class, as well as the `subscribe` method. In addition this adds the `Subscriber` internal class allows Observables to be subscribed to, and some additional machinery such as `SubscribeOptions`, `SubscriptionObserver` and so on. This also includes a fix to IDL generation to correctly generate callback function + dictionary unions (whatwg/webidl#1353). This does not implement any of the prototype methods on Observable, (other than subscribe) such as `takeUntil`, `filter`, `finally` and so on. * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any.worker-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/IDLTypes.h: * Source/WebCore/bindings/js/JSDOMConvertUnion.h: * Source/WebCore/bindings/js/JSSubscriberCustom.cpp: Added. (WebCore::JSSubscriber::visitAdditionalChildren): * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (AreTypesDistinguishableForOverloadResolution): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.cpp: Added. (WebCore::JSTestCallbackWithFunctionOrDict::JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::~JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::handleEvent): (WebCore::JSTestCallbackWithFunctionOrDict::visitJSFunction): (WebCore::toJS): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.h: Added. (WebCore::toJS): * Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep: * Source/WebCore/bindings/scripts/test/TestCallbackOrDict.idl: Added. * Source/WebCore/dom/Observable.cpp: Added. (WebCore::Observable::create): (WebCore::Observable::subscribe): (WebCore::Observable::makeSubscriber): (WebCore::Observable::Observable): * Source/WebCore/dom/Observable.h: Added. * Source/WebCore/dom/Observable.idl: Added. * Source/WebCore/dom/SubscribeOptions.h: Added. * Source/WebCore/dom/SubscribeOptions.idl: Added. * Source/WebCore/dom/Subscriber.cpp: Added. (WebCore::Subscriber::create): (WebCore::Subscriber::Subscriber): (WebCore::Subscriber::next): (WebCore::Subscriber::error): (WebCore::Subscriber::complete): (WebCore::Subscriber::addTeardown): (WebCore::Subscriber::followSignal): (WebCore::Subscriber::close): (WebCore::Subscriber::isInactiveDocument const): * Source/WebCore/dom/Subscriber.h: Added. * Source/WebCore/dom/Subscriber.idl: Added. * Source/WebCore/dom/SubscriberCallback.h: Added. * Source/WebCore/dom/SubscriberCallback.idl: Added. * Source/WebCore/dom/SubscriptionObserver.h: Added. * Source/WebCore/dom/SubscriptionObserver.idl: Added. * Source/WebCore/dom/SubscriptionObserverCallback.h: Added. * Source/WebCore/dom/SubscriptionObserverCallback.idl: Added.

https://bugs.webkit.org/show_bug.cgi?id=276572 Reviewed by NOBODY (OOPS!). This implements the base `Observable` class, as well as the `subscribe` method. In addition this adds the `Subscriber` internal class allows Observables to be subscribed to, and some additional machinery such as `SubscribeOptions`, `SubscriptionObserver` and so on. This also includes a fix to IDL generation to correctly generate callback function + dictionary unions (whatwg/webidl#1353). This does not implement any of the prototype methods on Observable, (other than subscribe) such as `takeUntil`, `filter`, `finally` and so on. * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any.worker-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/IDLTypes.h: * Source/WebCore/bindings/js/JSDOMConvertUnion.h: * Source/WebCore/bindings/js/JSSubscriberCustom.cpp: Added. (WebCore::JSSubscriber::visitAdditionalChildren): * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (AreTypesDistinguishableForOverloadResolution): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.cpp: Added. (WebCore::JSTestCallbackWithFunctionOrDict::JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::~JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::handleEvent): (WebCore::JSTestCallbackWithFunctionOrDict::visitJSFunction): (WebCore::toJS): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.h: Added. (WebCore::toJS): * Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep: * Source/WebCore/bindings/scripts/test/TestCallbackOrDict.idl: Added. * Source/WebCore/dom/Observable.cpp: Added. (WebCore::Observable::create): (WebCore::Observable::subscribe): (WebCore::Observable::makeSubscriber): (WebCore::Observable::Observable): * Source/WebCore/dom/Observable.h: Added. * Source/WebCore/dom/Observable.idl: Added. * Source/WebCore/dom/SubscribeOptions.h: Added. * Source/WebCore/dom/SubscribeOptions.idl: Added. * Source/WebCore/dom/Subscriber.cpp: Added. (WebCore::Subscriber::create): (WebCore::Subscriber::Subscriber): (WebCore::Subscriber::next): (WebCore::Subscriber::error): (WebCore::Subscriber::complete): (WebCore::Subscriber::addTeardown): (WebCore::Subscriber::followSignal): (WebCore::Subscriber::close): (WebCore::Subscriber::isInactiveDocument const): (WebCore::Subscriber::reportErrorObject): * Source/WebCore/dom/Subscriber.h: Added. * Source/WebCore/dom/Subscriber.idl: Added. * Source/WebCore/dom/SubscriberCallback.h: Added. * Source/WebCore/dom/SubscriberCallback.idl: Added. * Source/WebCore/dom/SubscriptionObserver.h: Added. * Source/WebCore/dom/SubscriptionObserver.idl: Added. * Source/WebCore/dom/SubscriptionObserverCallback.h: Added. * Source/WebCore/dom/SubscriptionObserverCallback.idl: Added.

https://bugs.webkit.org/show_bug.cgi?id=276572 Reviewed by Ryan Reno. This implements the base `Observable` class, as well as the `subscribe` method. In addition this adds the `Subscriber` internal class allows Observables to be subscribed to, and some additional machinery such as `SubscribeOptions`, `SubscriptionObserver` and so on. This also includes a fix to IDL generation to correctly generate callback function + dictionary unions (whatwg/webidl#1353). This does not implement any of the prototype methods on Observable, (other than subscribe) such as `takeUntil`, `filter`, `finally` and so on. * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-constructor.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-takeUntil.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/dom/observable/tentative/observable-toArray.any.worker-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/IDLTypes.h: * Source/WebCore/bindings/js/JSDOMConvertUnion.h: * Source/WebCore/bindings/js/JSSubscriberCustom.cpp: Added. (WebCore::JSSubscriber::visitAdditionalChildren): * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (AreTypesDistinguishableForOverloadResolution): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.cpp: Added. (WebCore::JSTestCallbackWithFunctionOrDict::JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::~JSTestCallbackWithFunctionOrDict): (WebCore::JSTestCallbackWithFunctionOrDict::handleEvent): (WebCore::JSTestCallbackWithFunctionOrDict::visitJSFunction): (WebCore::toJS): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackWithFunctionOrDict.h: Added. (WebCore::toJS): * Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep: * Source/WebCore/bindings/scripts/test/TestCallbackOrDict.idl: Added. * Source/WebCore/dom/Observable.cpp: Added. (WebCore::Observable::create): (WebCore::Observable::subscribe): (WebCore::Observable::makeSubscriber): (WebCore::Observable::Observable): * Source/WebCore/dom/Observable.h: Added. * Source/WebCore/dom/Observable.idl: Added. * Source/WebCore/dom/SubscribeOptions.h: Added. * Source/WebCore/dom/SubscribeOptions.idl: Added. * Source/WebCore/dom/Subscriber.cpp: Added. (WebCore::Subscriber::create): (WebCore::Subscriber::Subscriber): (WebCore::Subscriber::next): (WebCore::Subscriber::error): (WebCore::Subscriber::complete): (WebCore::Subscriber::addTeardown): (WebCore::Subscriber::followSignal): (WebCore::Subscriber::close): (WebCore::Subscriber::isInactiveDocument const): (WebCore::Subscriber::reportErrorObject): * Source/WebCore/dom/Subscriber.h: Added. * Source/WebCore/dom/Subscriber.idl: Added. * Source/WebCore/dom/SubscriberCallback.h: Added. * Source/WebCore/dom/SubscriberCallback.idl: Added. * Source/WebCore/dom/SubscriptionObserver.h: Added. * Source/WebCore/dom/SubscriptionObserver.idl: Added. * Source/WebCore/dom/SubscriptionObserverCallback.h: Added. * Source/WebCore/dom/SubscriptionObserverCallback.idl: Added. Canonical link: https://commits.webkit.org/281040@main

Add distinguishable state for cb and dictionary-like

b274797

vmpstr mentioned this pull request Aug 16, 2023

Allow dictionaries and callbacks to be distinguishable #1191

Closed

bathos reviewed Aug 16, 2023

View reviewed changes

index.bs Outdated Show resolved Hide resolved

review

adf1956

jeremyroman approved these changes Aug 17, 2023

View reviewed changes

vmpstr added 2 commits August 21, 2023 14:06

review

707ab32

review

b4024c5

vmpstr mentioned this pull request Aug 21, 2023

[css-view-transitions-2] Syntax for customizing transitions based on their type w3c/csswg-drafts#8960

Closed

domenic approved these changes Aug 21, 2023

View reviewed changes

index.bs Outdated Show resolved Hide resolved

Update index.bs

c3bf764

Co-authored-by: Domenic Denicola <[email protected]>

chromium-wpt-export-bot mentioned this pull request Oct 24, 2023

VTTypes: Add the IDL syntax to support the VT types feature. web-platform-tests/wpt#42723

Closed

domenic mentioned this pull request Nov 8, 2023

subscribe(fn) and/or subscribe(observer) WICG/observable#71

Closed

domfarolino mentioned this pull request Nov 29, 2023

Support Observer callback union for subscription WICG/observable#89

Merged

domenic mentioned this pull request Jan 12, 2024

Allow for global objects with a mutable prototype chain #1381

Merged

5 tasks

annevk merged commit 857ba61 into whatwg:main Jan 15, 2024

vmpstr deleted the cb_dict_distinguish branch January 29, 2024 21:05

This was referenced Jan 29, 2024

Add distinguishing between callback and dictionary-like types plinss/widlparser#84

Closed

Add distinguishing between callback and dictionary-like types w3c/webidl2.js#768

Open

keithamus mentioned this pull request Jul 15, 2024

Implement Observable class and subscribe method. WebKit/WebKit#23067

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add distinguishable state for cb and dictionary-like #1353

Add distinguishable state for cb and dictionary-like #1353

vmpstr commented Aug 16, 2023 •

edited

Loading

bathos commented Aug 16, 2023

jeremyroman left a comment

jeremyroman Aug 17, 2023

jeremyroman Aug 17, 2023

vmpstr Aug 21, 2023

jeremyroman Aug 21, 2023

vmpstr Aug 21, 2023

jeremyroman Aug 21, 2023

domenic left a comment

yuki3 commented Oct 27, 2023

lukewarlow commented Jan 12, 2024 •

edited

Loading

annevk commented Jan 15, 2024

keithamus commented Jan 15, 2024 •

edited

Loading

annevk commented Jan 15, 2024

vmpstr commented Jan 29, 2024

saschanaz commented Jan 29, 2024

vmpstr commented Jan 29, 2024

Add distinguishable state for cb and dictionary-like #1353

Add distinguishable state for cb and dictionary-like #1353

Conversation

vmpstr commented Aug 16, 2023 • edited Loading

bathos commented Aug 16, 2023

jeremyroman left a comment

Choose a reason for hiding this comment

jeremyroman Aug 17, 2023

Choose a reason for hiding this comment

jeremyroman Aug 17, 2023

Choose a reason for hiding this comment

vmpstr Aug 21, 2023

Choose a reason for hiding this comment

jeremyroman Aug 21, 2023

Choose a reason for hiding this comment

vmpstr Aug 21, 2023

Choose a reason for hiding this comment

jeremyroman Aug 21, 2023

Choose a reason for hiding this comment

domenic left a comment

Choose a reason for hiding this comment

yuki3 commented Oct 27, 2023

lukewarlow commented Jan 12, 2024 • edited Loading

annevk commented Jan 15, 2024

keithamus commented Jan 15, 2024 • edited Loading

annevk commented Jan 15, 2024

vmpstr commented Jan 29, 2024

saschanaz commented Jan 29, 2024

vmpstr commented Jan 29, 2024

vmpstr commented Aug 16, 2023 •

edited

Loading

lukewarlow commented Jan 12, 2024 •

edited

Loading

keithamus commented Jan 15, 2024 •

edited

Loading