Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps 20241119 #254

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

arpadav
Copy link

@arpadav arpadav commented Nov 19, 2024

Updated deps in Cargo.toml

  • Removal of clap (unused)
  • tungstenite:0.24 has url feature which is optional, added since connection uses a parsed url::Url
  • Other general crate updates

Tungstenite update

  • read_message and write_message are deprecated and replaced with read and send, respectively

General/small fixes

  • error_chain::bail already expands to return .., and multiple times return bail!(..) was called which expands to return return ... Removed unnecessary return
  • in binance::util::is_start_time_valid, made the if-statement branchless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant