Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(fr): update migrate-to-astro/from-gatsby.mdx #10820

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ArmandPhilippot
Copy link
Member

@ArmandPhilippot ArmandPhilippot commented Jan 28, 2025

Description (required)

Related issues & labels (optional)

  • Suggested label: i18n

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 28, 2025
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 32a9533
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/679b7337922a780008239105
😎 Deploy Preview https://deploy-preview-10820--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 28, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
fr/guides/migrate-to-astro/from-gatsby.mdx Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

<LinkCard title="Migrer mon site web de Gatsby vers Astro (en)" href="https://dev.to/flashblaze/migrating-my-website-from-gatsby-to-astro-2ej5"
description="Astro est soudainement apparu." />

<LinkCard title="De l’impasse de Gatsby au bonheur Astro : la refonte de mon site personnel (en)" href="https://jwn.gr/posts/migrating-from-gatsby-to-astro/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense que c'est préférable de dire d'Astro, mais il est possible qu'une ancienne discussion me contre-dise.

Suggested change
<LinkCard title="De l’impasse de Gatsby au bonheur Astro : la refonte de mon site personnel (en)" href="https://jwn.gr/posts/migrating-from-gatsby-to-astro/"
<LinkCard title="De l’impasse de Gatsby au bonheur d'Astro : la refonte de mon site personnel (en)" href="https://jwn.gr/posts/migrating-from-gatsby-to-astro/"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai répondu sur Discord, mais je remets ça:

J'avais hésité. Mais je me suis abstenu parce que le bonheur c'est Astro (donc sans d'), il n'appartient pas à Astro (d'Astro). Je ne sais pas si je suis clair.

Donc si quelqu'un d'autre veut jeter un oeil à la traduction, il est le bienvenu ! Ce n'est pas une modification urgente. 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense que le mieux serait d'enlever d'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a previous discussion that I can't find any trace of, the d' was explicitly asked to be avoided for Astro. I just asked in the doubt.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je mets ma suggestion ici :

Suggested change
<LinkCard title="De l’impasse de Gatsby au bonheur Astro : la refonte de mon site personnel (en)" href="https://jwn.gr/posts/migrating-from-gatsby-to-astro/"
<LinkCard title="De l’impasse Gatsby au bonheur Astro : la refonte de mon site personnel (en)" href="https://jwn.gr/posts/migrating-from-gatsby-to-astro/"

Puisque on est d'accord pour ne pas utiliser d', et à force de relire, ça me paraît plus équilibré sans de devant Gatsby.

Thomas ne semble pas contre, ça te convient aussi @pioupia ou tu préfères la version actuelle ?

Copy link
Contributor

@pioupia pioupia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ArmandPhilippot
Copy link
Member Author

ArmandPhilippot commented Jan 29, 2025

Well, I updated this PR with the new community resource merged in #10813! And there is still the problem of translation for the other one.

Edit: hum, tomorrow there will be version 5.2 and this same file will be updated again... This is a small update but we need to make sure we don't forget it before merging!

@ArmandPhilippot
Copy link
Member Author

File updated, ready to merge once reviewed and #10820 (comment) is resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants