-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: AsyncWebServer queue support #4119
Conversation
Update ESPAsyncWebserver and AsyncTCP dependency calls to the queue supporting branches.
Enable the new concurrent request and queue size limit features of AsyncWebServer. This should improve the handling of burst traffic or many clients, and significantly reduce the likelihood of OOM crashes due to HTTP requests.
This can be helpful for debugging web handler related issues.
Use the web server's queuing mechanism to call us back later.
No locking contention, but a much larger target
Update based on empirical data on an ESP32-WROVER, -WROOM, and -S2.
When I get home from vacation I'll give it a spin. |
My turn to forget the 'v'
Sorry for the long delay but now I finally managed to give AWS 2.3.0 + AsyncTCP 1.3.0 a spin. ESP32 code increases 0.5-0.6% which is substantial (my build goes t. 98.9%). |
Thanks for the testing! Re ESP8266 heap: I'll review what's going on there. |
Fixes outbound connection issues.
Hmm.. I couldn't reproduce either issue right away. ESP8266 - build time: 0_15: aws-queue: Runtime gave me the same output, 21.3kb free. Is it possible there was a second browser window or some other integration active during your testing? esp32dev: 0_15: aws-queue: So I'm seeing about 2.6k size increase (0.1%). Not ideal, and maybe I can improve, but not huge either. Would you mind sending me your build and runtime configs? |
Old 2.2.1: New 2.3.0: The only difference is in libraries and the change in json.cpp and wled_server.cpp. Test at home (on mac): New 2.3.0 The environment might be slightly different between computers. |
Thanks - I wonder what's different between our environments? I do expect some code size increase -- the queuing logic isn't going to be free, unfortunately -- but 6k does seem like a lot more than I'd've expected. If you can point me at where I can replicate your config/target, I'll see what I can do. I'm out of town this weekend, though, so I might not get to it until next week. |
Superseded with #4480. |
So, there is no more need to test this? Do I revert all my environments? |
I think it's about as tested as it can get without moving in to main with a wider audience. I've rebased it and opened a new PR #4480 to keep the changeset simple and avoid the complex merge. |
Add queuing capabilities to AsyncWebServer, allowing deferred request handling to spread out memory load, generating 503 responses when the device is overloaded, and effectively preventing the web API from causing OOM crashes.
This PR should be considered beta quality; the upstream branch has not yet been merged, pending wider testing. I've tested it as thoroughly as I can, given my limited stable of devices, and I have run out of ways to make them hang or crash with
curl
. Please consider merging this branch with your work-in-progress code to try it in more devices and under different load conditions.