Use UTF-8 functions of SQLite to avoid unexpected data type conversions #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkauf Would you be willing to rebase this on master and provide some tests to confirm your code works like you think it should? |
|
@gitblit I have updated the pull request and written a test. |
|
@mkauf Sorry, about this but would you be willing to rebase this one more time? |
|
@gitblit OK, done |
| @@ -396,4 +397,22 @@ public native synchronized int restore(String dbName, String sourceFileName, Pro | |||
| static void throwex(String msg) throws SQLException { | |||
| throw new SQLException(msg); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
These string util methods should move to org.sqlite.util.StringUtils.
There was a problem hiding this comment.
Ah. Well that complicates the native implementation, doesn't it.
|
Thank you for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't use modified UTF-8, see #61
Convert Java Strings to "unmodified" UTF-8 and vice versa.
Improve out-of-memory handling.
Fixes #78