Harmonize TrackLog and ClientError #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to populate Map params, TrackService now submits url, appEnv, appVer to db
…tJSON to populate clientErrorService params
…troduction of new services for admin console grids
6 tasks
lbwexler
reviewed
Apr 2, 2024
lbwexler
reviewed
Apr 2, 2024
|
Looks great jacob -- will be nice to have these back in line |
lbwexler
reviewed
Apr 2, 2024
…ON calls to simplify service method calls
amcclain
pushed a commit
to xh/hoist-react
that referenced
this pull request
Apr 3, 2024
+ Update to new APIs just merged into hoist-core (xh/hoist-core#344) for posting client error and activity tracking queries + Update Admin Client Error query tool to post filter params to server for DB-level querying, as was recently done with Activity Tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new fields to TrackLog and ClientError databases to consolidate the two (to the extent that it makes sense)
It also refactors the
XhControllerendpoints fortrackandsubmitErrorto expect the input parameters to be posted as JSON to the request body. One note about this change, because of the current implementation of theensureClientUsernameMatchesSessionmethod,clientUsernamestill needs to be posted to the server as aparam.Finally, this server-side change refactors the
ClientErrorAdminControllerto use a new service, theClientErrorAdminService, to use filters provided by the client to do server-side filtering (this pattern is used inTrackLogAdminControllerandTrackLogAdminService).