Skip to content

Commit

Permalink
Merge pull request #53 from xh/develop
Browse files Browse the repository at this point in the history
v8.1.1 - ensure there is only one version of ag-grid's hook contexts when running with hoist-react inline
  • Loading branch information
cnrudd authored May 10, 2024
2 parents 4cd32d7 + 875da40 commit 158d68a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## v8.1.1 - 2024-05-10

### ⚙️ Technical

* Added another `resolveAliases` entry to ensure that the same instance of `@ag-grid-community` is used when
developing inline. This ensures there is only one version of ag-grid's hook contexts.

## v8.1.0 - 2024-03-27

### 🎁 New Features
Expand Down
7 changes: 4 additions & 3 deletions configureWebpack.js
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,12 @@ async function configureWebpack(env) {
if (inlineHoist) {
resolveAliases['@xh/hoist'] = hoistPath;

// This ensures that we use the same instance of react in hoist-react as in the app - needed
// to get hooks working since they will throw an error if the react instance that the hook
// This ensures that we use the same instance of libs in hoist-react as in the app - needed
// to get hooks working since they will throw an error if the lib instance that the hook
// was imported from is different than the instance that was used to render the component
// (which will always be the instance hoist-react has when using element factories)
resolveAliases.react = path.resolve('./node_modules/react');
resolveAliases['react'] = path.resolve('./node_modules/react');
resolveAliases['@ag-grid-community'] = path.resolve('./node_modules/@ag-grid-community');
}

// When running inline, resolve inline Hoist's own node_modules package so we can tell Babel to exclude
Expand Down

0 comments on commit 158d68a

Please sign in to comment.