-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hoist dialog #1497
Closed
Closed
Hoist dialog #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to chrome v79 fixed the issue.
+ Fix css for for handle cursor + Cannot create a default model since a model is needed to show() dialog.
+ cleanup BEM naming.
Colin and I are now working together on this in earnest. Looking great! |
Closing this PR. Development of a Hoist Dialog has moved to a new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
This PR is for Hoist React ticket #861 .
This hoistDialog branch should be run with the new hoistDialog branch in toolbox. See toolbox PR 311.
This new Dialog component makes draggable an option on dialogs.
If a dialog is draggable, it opens centered with no mask behind it.
The component is a WIP. More work needs to be done to be sure that the following use cases work:
Content with forms with autofocus fields and buttons, select and datepicker fields which when the select menu or datepicker popup close on escape and enter, the dialog does not close.
Also needed:
Would also be good to rewrite all XH.messages to use this new dialog. That would be a good collection of tests.
Hoist P/R Checklist
Review and check off the below. Items that do not apply can also be checked off to indicate they
have been considered. If unclear if a step is relevant, please leave unchecked and note in comments.
develop
branch as of last change.wip
label).breaking-change
label + CHANGELOG if so, or N/A)