Mobile menus 2.0. #2232
Merged
Mobile menus 2.0. #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Menus and MenuButtons no longer requires a model. + Menus and MenuButtons can be provided menu items as props. + MenuButton uses popperjs and blueprint-style position system, to position the menu relative to the button. + Removed AppMenuModel in favor of passing `extraItems` to AppMenuButton via AppBar. This is consistent with Desktop.
|
Nice -- looking forward to reviewing! |
# Conflicts: # mobile/cmp/menu/MenuModel.js
# Conflicts: # mobile/cmp/button/MenuButton.js # mobile/cmp/header/AppMenuModel.js # mobile/cmp/header/index.js # mobile/cmp/menu/Menu.js # mobile/cmp/menu/MenuModel.js # mobile/cmp/menu/index.js # yarn.lock
+ Move Menu to menu/impl package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new and improved menu system for mobile, intended to provide a more useful API and to iron out some of the inconsistencies with desktop:
extraItemsto AppMenuButton via AppBar. This is consistent with Desktop.See issue: #2230
See Toolbox PR: xh/toolbox#457
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.breaking-changelabel + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.