-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize column state sync #3905
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a great simplification and clean-up - and now I see why we saw performance worsen in proportion to number of columns being shown/hidden!
Eager to take it - just now wondering if it requires update to AG v32....
cmp/grid/Grid.ts
Outdated
colState.splice( | ||
agColState.indexOf(autoColState), | ||
0, | ||
autoColState as ColumnState |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this case risk spoiling the change detection below due to unfortunate hide/hidden mismatch?
I know it's an edge-case where we have this auto-column inserted by the grid - it's due to direct use of AG-grid grouping APIs, is that right? So maybe nothing we need to worry about, just checking if there's some tweak we would make to get it 100%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, only an issue when using ag-grid grouping without full-row groups, but worthwhile to be correct
If you haven't already, we should have a look over the calls to |
Partial fix for #3903
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
develop
branch as of last change.breaking-change
label + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.