Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-micro-runtime: add latest version (2.2.0) #6283

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

ethindp
Copy link

@ethindp ethindp commented Feb 4, 2025

This PR adds version 2.2.0 of WAMR. I have verified that it builds (without need for patches) with both the default configuration and with a modified configuration enabling most options.

@ethindp
Copy link
Author

ethindp commented Feb 4, 2025

I'm a bit confused on the failures here, it builds fine on my machine (though I'm using VS2022 so... Maybe that's it?). The error looks like it can't find a kernel function but that doesn't make any sense, the CMakeLists should be handling that part.

@ethindp
Copy link
Author

ethindp commented Feb 4, 2025

Okay, so it looks like, for the failing windows targets, it's trying to redefine NtQueryTimerResolution. I'm not entirely sure why it's trying to redefine this function, but I'm also very confused why it's succeeding on many other windows targets but not on these ones.

@star-hengxing
Copy link
Contributor

@ethindp
Copy link
Author

ethindp commented Feb 6, 2025

@star-hengxing I didn't know about that one, thanks for that, I believe I applied it correctly.

@ethindp
Copy link
Author

ethindp commented Feb 7, 2025

cc @waruqi

@ethindp
Copy link
Author

ethindp commented Feb 8, 2025

I just tried to fix the patch thing for windows by only having it apply on windows... Hopefully that fixes it.

@ethindp
Copy link
Author

ethindp commented Feb 8, 2025

@star-hengxing Looks like either I broke the patch somehow or something else is wrong, it's being rejected when it gets applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants