Vendor zarr imports #285
Merged
Vendor zarr imports #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…matt/protect-zarr-imports
mpiannucci
commented
Dec 4, 2024
| @@ -49,9 +49,9 @@ def test_invalid_encoding_chunks_with_dask_raise(): | |||
| data = dask.array.zeros((10, 20, 30), chunks=expected) | |||
| ds = xr.Dataset({'foo': (['x', 'y', 'z'], data)}) | |||
| ds['foo'].encoding['chunks'] = [8, 5, 1] | |||
| with pytest.raises(ValueError) as excinfo: | |||
There was a problem hiding this comment.
Running against the latest xarray, this throws an TypeError because region in the xarray dask check is None so it cant even compute the check
abkfenris
approved these changes
Jan 3, 2025
|
Dear @abkfenris |
|
Hi @mo-dkrz , I think @mpiannucci had something else that they wanted to land/let things settle with external libraries before cutting a new release. |
|
I think this is fine now that zarr 3 is out. We should add a CI test for it though to make sure |
|
Thanks for explanation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xpublish should be zarr python version agnostic, this is the first step in getting xpublish running with zarr python 3