Allow extensions to hook into the get/set content #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange the html that is being set/get. Moved the extension init before the addElements method to allow extension hook into the setContent and getContent. Because of the move the elements are not available in the extension init method, the extension should subscribe to the add addElement and removeElement events. Always enable toolbar when not disabled in options, even when all elements on page have data-disable-toolbar set, it is possible that elements are added later that require the toolbar.
|
Changes Unknown when pulling 901ce97 on DMXzone:master into ** on yabwe:master**. |
…extensions to update the editable html. tests needed an update because the innerHTML of the content editable was replaced after init.
|
Changes Unknown when pulling 20dc823 on DMXzone:master into ** on yabwe:master**. |
|
Changes Unknown when pulling 3a9ee74 on DMXzone:master into ** on yabwe:master**. |
… created after a enter to a p tag, this is now catched. Fix for when applying block formatting when on a list item, it will remove list formatting first. fixed issue yabwe#1348
|
Changes Unknown when pulling aac63d4 on DMXzone:master into ** on yabwe:master**. |
|
Changes Unknown when pulling e3706c2 on DMXzone:master into ** on yabwe:master**. |
|
Any updates on this getting merged in? I'm especially interested in the fix for #1348 |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all methods that set/get the editor content, extensions can change the html that is being set/get.
Moved the extension init before the addElements method to allow
extension hook into the setContent and getContent. Because of the move
the elements are not available in the extension init method, the
extension should subscribe to the add addElement and removeElement
events.
Always enable toolbar when not disabled in options, even when all
elements on page have data-disable-toolbar set, it is possible that
elements are added later that require the toolbar.
Description
Extensions can manipulate the html set/get from the editor
--
Please, don't submit
/distfiles with your PR!