Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ascanrules: Address SSTI false positive #5802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ascanrules: Address SSTI false positive #5802

wants to merge 1 commit into from

Conversation

kingthorin
Copy link
Member

Overview

  • CHANGELOG > Fix note
  • SstiScanRule > Adjust logic to prevent False Positives.
  • SstiScanRuleUnitTest > Updated for adjusted logic.

Related Issues

Checklist

  • [na] Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@kingthorin kingthorin force-pushed the ssti-fix branch 2 times, most recently from 77cac15 to a96bc38 Compare October 9, 2024 13:46
@psiinon
Copy link
Member

psiinon commented Oct 9, 2024

Have you tested this against the "Websites Vulnerable to SSTI" app?

@kingthorin
Copy link
Member Author

Yup, sorry I meant to mention that. Yes I did grab the docker image and test before/after. Everything is still found that was originally.

@kingthorin
Copy link
Member Author

kingthorin commented Oct 14, 2024 •
edited
Loading

Tweaked and de-conflicted.

@kingthorin
ascanrules: Address SSTI false positive
b1144e1 
- CHANGELOG > Fix note
- SstiScanRule > Adjust logic to prevent False Positives.
- SstiScanRuleUnitTest > Updated for adjusted logic.

Signed-off-by: kingthorin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thc202 thc202 thc202 left review comments

@rbliss rbliss rbliss left review comments

@psiinon psiinon psiinon approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server-Side Template Injection (SSTI) False Positive
4 participants
@kingthorin @psiinon @rbliss @thc202