Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence - use new seq scan in desktop #5899

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

psiinon
Copy link
Member

@psiinon psiinon commented Nov 7, 2024

Overview

Switch to use the new seq ascan - it works better and is faster.
We should revisit the help at some point.

Related Issues

#5897 - mayneed to change to use this for the default policy

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

For more details, please refer to the developer rules and guidelines.

Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update help and changelog?

@psiinon
Copy link
Member Author

psiinon commented Nov 11, 2024

Have updated the changelog. We have another task for updating the help, that might take more effort :)

Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but seems reasonable

@thc202
Copy link
Member

thc202 commented Nov 11, 2024

Thank you!

@thc202 thc202 merged commit 676d9e8 into zaproxy:main Nov 11, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants