zaproxy · jaywon · Mar 17, 2019 · Mar 17, 2019 · Mar 17, 2019 · Mar 17, 2019
diff --git a/src/main/zapHomeFiles/hud/libs/event-bus.js b/src/main/zapHomeFiles/hud/libs/event-bus.js
@@ -0,0 +1,2 @@
+import Vue from 'vue';
+export const EventBus = new Vue();
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		import Vue from 'vue';
		export const EventBus = new Vue();
Copy link Contributor dscrobonia Mar 26, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. love this shared module jaywon reacted with laugh emoji Copy link Contributor nothingismagick Apr 23, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Because the events are registered in this external bus, they all need to be individually torn down: e.g. `beforeDestroy () { eventBus.$off('showSiteTreeModal') }` You could create a global mixin here, but I think that the difficulty you would face is that you will have to contort yourself to know which component is being destroyed. Probably better to tear them down in the individual components, because that way later contributors can SEE that they are being unregistered.