Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Prettified files using command npx prettier --write . #552

Closed
wants to merge 1 commit into from
Closed

[WIP] Prettified files using command npx prettier --write . #552

wants to merge 1 commit into from

Conversation

njmulsqb
Copy link
Contributor

@njmulsqb njmulsqb commented Sep 4, 2021

Hi,

I saw an issue #8 which mentioned the need of prettier on the code of zap website.

I have prettified whole website's code using prettier extension with the following command
npx prettier --write .

Reference: https://stackoverflow.com/questions/43666270/how-do-i-format-all-files-in-a-visual-studio-code-project

@thc202
Copy link
Member

thc202 commented Sep 4, 2021

That issue is about changing the build to verify (and allow to apply) the format, not just for one-off.

@thc202 thc202 changed the title Prettified files using command npx prettier --write . [WIP] Prettified files using command npx prettier --write . Sep 5, 2021
@njmulsqb
Copy link
Contributor Author

njmulsqb commented Sep 6, 2021

That issue is about changing the build to verify (and allow to apply) the format, not just for one-off.

Sorry but the issue does not contains any detailed description, it just says "Prettify the code" which I did, nothing else mentioned.

@thc202
Copy link
Member

thc202 commented Sep 6, 2021

Yes, sometimes the issues don't contain all required information.

@njmulsqb
Copy link
Contributor Author

njmulsqb commented Sep 6, 2021

Yes, sometimes the issues don't contain all required information.

Anyways, if you explain this issue to me in detail, I can work on it.

@thc202
Copy link
Member

thc202 commented Sep 6, 2021

It's as mentioned in the previous comment, the build should verify and allow to apply the format.

@njmulsqb njmulsqb closed this Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants