Skip to content

Commit

Permalink
Merge pull request #298 from thc202/rm-quit
Browse files Browse the repository at this point in the history
Remove workaround no longer needed
  • Loading branch information
kingthorin authored Feb 10, 2025
2 parents e1d93c6 + 53e8d34 commit 8cb45f6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
### Changed
- Update Selenium to version 4.28.1.
- Remove workaround that was now causing exceptions.

## [0.23.0] - 2025-01-23
### Changed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,6 @@ public String invoke(ZestRuntime runtime) {
// Ignore, it might have already closed
}
runtime.removeWebDriver(getWindowHandle());

if (runtime.getWebDrivers().size() == 0 && this.getNext() == null) {
// We've closed all of the windows and this is the last statement
// Explicitly quit - currently needed for the phantomjs driver, otherwise it never
// returns :/
wd.quit();
}
}

return null;
Expand Down

0 comments on commit 8cb45f6

Please sign in to comment.