Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Allow searching on fetchall #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erictinocopro
Copy link

Added param to allow searching on fetchall method
Fix wrong usage of ObjectPropertyHydrator on constructor

Fix wrong call to hydrator
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas-api-tools/statuslib-example; a new issue has been opened at laminas-api-tools/statuslib-example#1.

@weierophinney
Copy link
Member

This repository has been moved to laminas-api-tools/statuslib-example. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas-api-tools/statuslib-example to another directory.
  • Copy the files from the second bullet point to the clone of laminas-api-tools/statuslib-example.
  • In your clone of laminas-api-tools/statuslib-example, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants