std.Build.Dependency: add optional~ functions #21841
Open
+18
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
std.Build.Dependency
relies on a transitiveb.lazyDependency
to expose an artifact, module, namedWriteFiles or namedLazyPath, calls to these functions panic when the dependency was not downloaded yet, but work fine when it is available in the local cache.We can prevent this by using
optionalArtifact
, returning an optional instead of panic.Same for
optionalModule
,optionalNamedWriteFiles
andoptionalNamedLazyPath
.I think the
optional~
prefix is better thanlazy~
here to avoid confusion withLazyPath
.The downside I guess is it could lead to dead code if the named Item will never be available...