Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate executable storage properly (v2) #512

Open
wants to merge 1 commit into
base: v2.x/staging
Choose a base branch
from

Conversation

ifakhrutdinov
Copy link
Contributor

@ifakhrutdinov ifakhrutdinov commented Feb 10, 2025

Proposed changes

Some storage that is intended to be executed is not allocated with the EXECUTABLE=YES option, can lead to ABENDs when certain z/OS options are set.

This PR changes the code which allocates such storage to allocate it with EXECUTABLE=YES.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings

Testing

You will need a z/OS system where the special diagnostics for non-executable storage has been enabled.

Do the following:

  • Regression testing of ZIS;
  • Cancel a ZIS instance to trigger the address space resource manager; no ABENDs should occur.

@ifakhrutdinov ifakhrutdinov changed the base branch from v3.x/staging to v2.x/staging February 10, 2025 19:36
@ifakhrutdinov ifakhrutdinov changed the title Bugfix/non exec storage v2 Allocate executable storage properly (v2) Feb 10, 2025
Some storage that is intended to be executed is not allocated with the
EXECUTABLE=YES option, can lead to ABENDs when certain z/OS options are
set.

This commit changes the code which allocates such storage to allocate it
with EXECUTABLE=YES.

Signed-off-by: Irek Fakhrutdinov <[email protected]>
@ifakhrutdinov ifakhrutdinov force-pushed the bugfix/non-exec-storage-v2 branch from e4b83c5 to a5e4b5a Compare February 10, 2025 19:44
@ifakhrutdinov ifakhrutdinov added the bug Something isn't working label Feb 10, 2025
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks identical to already merged v3 code #507 so approving this for v2.

@ifakhrutdinov
Copy link
Contributor Author

@1000TurquoisePogs , please don't merge this yet, I may need to make some additional changes in the zss repo (apart from the deps update).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants