android: Add app icon for F-Droid. #5897
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for pinging you @chrisbobbe but could you please take a quick look at this PR? |
Previously, fdroidserver was capable of somehow extracting the app icon. However, it is no longer and this is now the only way of providing an app icon.
leoheitmannruiz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, no app icon is associated with Zulip in the main F-Droid repository. As a result, F-Droid clients and repository browser don't display an icon: https://f-droid.org/packages/com.zulipmobile/. This should fix it.
I took the image from https://play.google.com/store/apps/details?id=com.zulipmobile, specifically https://play-lh.googleusercontent.com/JEo4Q5Ed3TIJRxL8A-moTh0HoYF74Hmg4WFISopAach2CjcpgSiTDQXU2d6JnxNz0g and compressed it using zopflipng.
Closes #5908