dev-cmd/edit: Move path specific functions to Pathname

Library/Homebrew/dev-cmd/edit.rb

@@ -7,6 +7,32 @@
 module Homebrew
   module_function
 
+  module Refinements
+    refine Pathname do
+      sig { returns(T::Boolean) }
+      def core_formula_path?
+        fnmatch?("**/homebrew-core/Formula/**.rb", File::FNM_DOTMATCH)
+      end
+
+      sig { returns(T::Boolean) }
+      def core_cask_path?
+        fnmatch?("**/homebrew-cask/Casks/**.rb", File::FNM_DOTMATCH)
+      end
+
+      sig { returns(T::Boolean) }
+      def core_formula_tap?
+        self == CoreTap.instance.path
+      end
+
+      sig { returns(T::Boolean) }
+      def core_cask_tap?
+        self == CoreCaskTap.instance.path
+      end
+    end
+  end
+
+  using Refinements
+
   sig { returns(CLI::Parser) }
   def edit_args
     Homebrew::CLI::Parser.new do
@@ -28,6 +54,40 @@ def edit_args
     end
   end
 
+  sig { params(path: Pathname, cask: T::Boolean).void }
+  def fail_with_message(path, cask)
+    name = path.basename(".rb").to_s
+
+    if (tap_match = Regexp.new("#{HOMEBREW_TAP_DIR_REGEX.source}$").match(path.to_s))
+      raise TapUnavailableError, CoreTap.instance.name if path.core_formula_tap?
+      raise TapUnavailableError, CoreCaskTap.instance.name if path.core_cask_tap?
+
+      raise TapUnavailableError, "#{tap_match[:user]}/#{tap_match[:repo]}"
+    elsif cask || path.core_cask_path?
+      if !CoreCaskTap.instance.installed? && Homebrew::API::Cask.all_casks.key?(name)
+        command = "brew tap --force #{CoreCaskTap.instance.name}"
+        action = "tap #{CoreCaskTap.instance.name}"
+      else
+        command = "brew create --cask --set-name #{name} $URL"
+        action = "create a new cask"
+      end
+    elsif path.core_formula_path? &&
+          !CoreTap.instance.installed? &&
+          Homebrew::API::Formula.all_formulae.key?(name)
+      command = "brew tap --force #{CoreTap.instance.name}"
+      action = "tap #{CoreTap.instance.name}"
+    else
+      command = "brew create --set-name #{name} $URL"
+      action = "create a new formula"
+    end
+
+    message = <<~EOS
+      #{name} doesn't exist on disk.
+      Run #{Formatter.identifier(command)} to #{action}!
+    EOS
+    raise UsageError, message
+  end
+
   sig { void }
   def edit
     args = edit_args.parse
@@ -50,56 +110,23 @@ def edit
         [HOMEBREW_REPOSITORY]
       end
     else
-      edit_api_message_displayed = T.let(false, T::Boolean)
-      args.named.to_paths.select do |path|
-        core_formula_path = path.fnmatch?("**/homebrew-core/Formula/**.rb", File::FNM_DOTMATCH)
-        core_cask_path = path.fnmatch?("**/homebrew-cask/Casks/**.rb", File::FNM_DOTMATCH)
-        core_formula_tap = path == CoreTap.instance.path
-        core_cask_tap = path == CoreCaskTap.instance.path
-
-        if path.exist?
-          if (core_formula_path || core_cask_path || core_formula_tap || core_cask_tap) &&
-             !edit_api_message_displayed &&
-             !Homebrew::EnvConfig.no_install_from_api? &&
-             !Homebrew::EnvConfig.no_env_hints?
-            opoo <<~EOS
-              `brew install` ignores locally edited #{(core_cask_path || core_cask_tap) ? "casks" : "formulae"} if
-              `HOMEBREW_NO_INSTALL_FROM_API` is not set.
-            EOS
-            edit_api_message_displayed = true
-          end
-          next path
-        end
+      expanded_paths = args.named.to_paths
+      expanded_paths.each do |path|
+        fail_with_message(path, args.cask?) unless path.exist?
+      end
 
-        name = path.basename(".rb").to_s
-
-        if (tap_match = Regexp.new(HOMEBREW_TAP_DIR_REGEX.source + /$/.source).match(path.to_s))
-          raise TapUnavailableError, CoreTap.instance.name if core_formula_tap
-          raise TapUnavailableError, CoreCaskTap.instance.name if core_cask_tap
-
-          raise TapUnavailableError, "#{tap_match[:user]}/#{tap_match[:repo]}"
-        elsif args.cask? || core_cask_path
-          if !CoreCaskTap.instance.installed? && Homebrew::API::Cask.all_casks.key?(name)
-            command = "brew tap --force #{CoreCaskTap.instance.name}"
-            action = "tap #{CoreCaskTap.instance.name}"
-          else
-            command = "brew create --cask --set-name #{name} $URL"
-            action = "create a new cask"
-          end
-        elsif core_formula_path && !CoreTap.instance.installed? && Homebrew::API::Formula.all_formulae.key?(name)
-          command = "brew tap --force #{CoreTap.instance.name}"
-          action = "tap #{CoreTap.instance.name}"
-        else
-          command = "brew create --set-name #{name} $URL"
-          action = "create a new formula"
+      expanded_paths.each do |path|
+        if (path.core_formula_path? || path.core_cask_path? || path.core_formula_tap? || path.core_cask_tap?) &&
+           !Homebrew::EnvConfig.no_install_from_api? &&
+           !Homebrew::EnvConfig.no_env_hints?
+          opoo <<~EOS
+            `brew install` ignores locally edited #{(path.core_cask_path? || path.core_cask_tap?) ? "casks" : "formulae"} if
+            HOMEBREW_NO_INSTALL_FROM_API is not set.
+          EOS
+          break
         end
-
-        message = <<~EOS
-          #{name} doesn't exist on disk.
-          Run #{Formatter.identifier(command)} to #{action}!
-        EOS
-        raise UsageError, message
-      end.presence
+      end
+      expanded_paths
     end
 
     if args.print_path?