-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Tap
.
#16730
Clean up Tap
.
#16730
Conversation
1b172c1
to
acb97ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again: let's wait a week or so before merging. There have been too many user-affecting regressions from refactors recently.
acb97ce
to
03278ab
Compare
ae6be47
to
ffbbab0
Compare
32911b7
to
51c434c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense although I do wonder whether the T.must
error messages are going to be end-user appropriate?
6471516
to
fbdc5c1
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Extracted from #16671.
From the changes in
Tap#clear_cache
you can actually see we were missing quite a few cached variables, which would be done automatically using #16671.