Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Tap. #16730

Closed
wants to merge 1 commit into from
Closed

Clean up Tap. #16730

wants to merge 1 commit into from

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Feb 23, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Extracted from #16671.

From the changes in Tap#clear_cache you can actually see we were missing quite a few cached variables, which would be done automatically using #16671.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again: let's wait a week or so before merging. There have been too many user-affecting regressions from refactors recently.

Library/Homebrew/cmd/update-report.rb Outdated Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense although I do wonder whether the T.must error messages are going to be end-user appropriate?

Copy link

github-actions bot commented Apr 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Apr 9, 2024
@github-actions github-actions bot closed this Apr 17, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label May 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants