unpack_strategy: fix unpack Dir.mktmpdir group #18548
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Otherwise the files will be unpacked with group wheel on macOS which gets copied over when running
cp -al
.This used to be implicitly "fixed" due to
cp -pR
usage which would recreate the files.After #18497, files that are copied via
cp -al
retain wheel group, which isn't what we want.Was exploring another alternative in #18518 but this seems like cleaner option.
Probably should move the logic to
utils/
or somewhere else that can be shared to avoid code duplication. Perhaps a follow up as would be good to avoid current bottles getting installed as wheel group.