Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocops/shared/url_helper: tweak SourceForge handling #18631

Merged
merged 1 commit into from
Oct 24, 2024
Merged

rubocops/shared/url_helper: tweak SourceForge handling #18631

merged 1 commit into from
Oct 24, 2024
+7 −3

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Oct 24, 2024

  • Allow http://download(s).sourceforge.net to be used as a plain HTTP mirror if the HTTPS equivalent is present
  • Ban download(s).sf.net as it always does a HTTPS -> HTTP redirect

@Bo98 Bo98 mentioned this pull request Oct 24, 2024
Merged
@Bo98 Bo98 merged commit 5538282 into master Oct 24, 2024
27 checks passed
@Bo98 Bo98 deleted the sf-fixes branch October 24, 2024 19:55
MikeMcQuaid
MikeMcQuaid reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bo98!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bo98 @MikeMcQuaid @carlocab