Fixed error when calling getTableNames() on a DuckDB connection. F…

…ixes #299
OHDSI · Jan 31, 2025 · 24ce059 · 24ce059
1 parent 0794d6e
commit 24ce059
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -5,6 +5,8 @@ Bugfixes:
 
 - Remove direct call to `bit64` S3 method to avoid issues in the future.
 
+- Fixed error when calling `getTableNames()` on a `DuckDB` connection.
+
 
 DatabaseConnector 6.4.0
 =======================

diff --git a/R/ListTables.R b/R/ListTables.R
@@ -117,7 +117,8 @@ getTableNames <- function(connection, databaseSchema = NULL, cast = "lower") {
   } else if (is(connection, "DatabaseConnectorConnection")) {
     tableNames <- DBI::dbListTables(conn = connection, databaseSchema = databaseSchema)
   } else if (is(connection, "PqConnection") || is(connection, "RedshiftConnection") || is(connection, "duckdb_connection")) {
-    stopifnot(length(databaseSchemaSplit) == 1)
+    databaseSchemaSplit <- strsplit(databaseSchema, "\\.")[[1]]
+    if (length(databaseSchemaSplit) > 1) rlang::abort("databaseSchema cannot contain a dot (.) on this platform")
     sql <- paste0("SELECT table_name FROM information_schema.tables WHERE table_schema = '", databaseSchema, "';")
     tableNames <- DBI::dbGetQuery(connection, sql)[["table_name"]]
   } else if (is(connection, "Microsoft SQL Server")) {