gz: remove model spawn offset #24165
Open
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
What does spawning at zero actually mean? I think the motivation for this was that some models would be spawned to penetrate the ground which results in the vehicle jumping up extremely high.
Not against the change, but not sure if this is the best way to fix this.
|
Well on those models it would be an easy fix to adjust the pose. I think that issue then might be a consequence of the px4-rc.simulator init script spawning all the models at 0,0,0, if unspecified with the env var |
Jaeyoung-Lim
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spawning of the model in the air is confusing in logs and right now is potentially impacting the EKF during initialization (specifically rangefinder alt source as primary). This was added in #22400 but IMO it would be better to fix the offending models on a case by case basis. In a perfect world the maintainer of a model/world would have the flexibility to spawn their model wherever they want.