-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent overflow of dt in Integrator class #24202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Jan 14, 2025
RomanBapst
force-pushed
the
pr-fix_integrator_overflow
branch
from
January 16, 2025 13:54
c4513df
to
50d9cf9
Compare
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: -48 byte (-0 %)]
px4_fmu-v6x [Total VM Diff: -48 byte (-0 %)]
Updated: 2025-01-21T12:28:24 |
RomanBapst
force-pushed
the
pr-fix_integrator_overflow
branch
from
January 20, 2025 07:21
50d9cf9
to
cdb9d7e
Compare
sfuhrer
approved these changes
Jan 20, 2025
Signed-off-by: RomanBapst <[email protected]>
Signed-off-by: RomanBapst <[email protected]>
Signed-off-by: RomanBapst <[email protected]>
RomanBapst
force-pushed
the
pr-fix_integrator_overflow
branch
from
January 21, 2025 12:23
cdb9d7e
to
ea780a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
I was using the integrator class for a sensor which published at 12 Hz, which equals a dt of roughly 80'000 us.
The integrator dt varialbe was using a uint16, which overflows at around 65'500.
Solution
Use an uint32 variable.
Changelog Entry
For release notes: