Documentation: Remove defaulting to "John Does" as airframe maintainer #24203
+1
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When looking at airframe documentation @RomanBapst found that it's ridiculous to have "John Doe" as maintainer for many airframes. It's just a mock person and the information doesn't add any value but just clutter the documentation and possibly even cause confusion.
Solution
Remove the default string for the maintainer defined in the airframe parsing script. If no maintainer is defined then no maintainer should be added.
Changelog Entry
Alternatives
We could also fail the parsing when no maintainer is defined but in my eyes that's too strict and gets into people's way.
Test coverage
It still parses and builds, we need to check that
None
actually causes the behavior we want or if it needs to be an empty string.Context