Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ekf2: yaw estimator additional validity checks #24228

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

dagar
Copy link
Member

@dagar dagar commented Jan 17, 2025

This tightens the yaw estimator validity requirements closing a potential hole. I don't think it's a real concern because it occured in an extreme case in simulation where the simulation was breaking down, but the additional checks could't hurt.

image

@dagar dagar added the EKF2 label Jan 17, 2025
@dagar dagar requested a review from bresch January 17, 2025 19:08
Copy link

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: 72 byte (0 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +72  +0.0%     +72    .text
  +1.0%     +48  +1.0%     +48    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  +0.0%     +24  +0.0%     +24    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
+0.0%     +28  [ = ]       0    .debug_frame
+0.0%     +50  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.1%     +76  [ = ]       0    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  -0.0%     -22  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-0.0%     -98  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.7%    +106  [ = ]       0    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  -0.0%    -174  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
  -0.4%      -5  [ = ]       0    task/task_cancelpt.c
+0.0%    +141  [ = ]       0    .debug_loc
  +0.1%     +43  [ = ]       0    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  +0.0%     +18  [ = ]       0    [section .debug_loc]
  +0.0%     +80  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-0.0%    -121  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  +0.4%     +24  [ = ]       0    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  -0.1%     -48  [ = ]       0    [section .debug_ranges]
  -0.0%     -88  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
  -1.5%      -1  [ = ]       0    task/task_cancelpt.c
+0.5%      +1  [ = ]       0    .shstrtab
+0.0%     +51  [ = ]       0    .strtab
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
  +0.0%     +32  [ = ]       0    [section .strtab]
  +0.3%     +51  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%     +48  [ = ]       0    .symtab
  -7.0%     -64  [ = ]       0    ../../src/lib/version/version.c
  +0.3%     +16  [ = ]       0    ../../src/modules/fw_pos_control/FixedwingPositionControl.cpp
  +0.1%     +48  [ = ]       0    [section .symtab]
  +0.3%     +48  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-0.6%     -72  [ = ]       0    [Unmapped]
+0.0%    +156  +0.0%     +72    TOTAL

px4_fmu-v6x [Total VM Diff: 72 byte (0 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +72  +0.0%     +72    .text
  +1.0%     +48  +1.0%     +48    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  +0.0%     +24  +0.0%     +24    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
+0.0%     +28  [ = ]       0    .debug_frame
+0.0%     +50  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.1%     +76  [ = ]       0    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  -0.0%     -22  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-0.0%     -90  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.7%    +106  [ = ]       0    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  -0.0%    -174  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
  +0.3%      +3  [ = ]       0    task/task_cancelpt.c
+0.0%    +132  [ = ]       0    .debug_loc
  +0.1%     +43  [ = ]       0    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  +0.0%     +20  [ = ]       0    [section .debug_loc]
  +0.0%     +69  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-0.0%    -120  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  +0.4%     +24  [ = ]       0    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  -0.1%     -48  [ = ]       0    [section .debug_ranges]
  -0.0%     -88  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.5%      +1  [ = ]       0    .shstrtab
+0.0%     +51  [ = ]       0    .strtab
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
  +0.0%     +32  [ = ]       0    [section .strtab]
  +0.3%     +51  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%     +48  [ = ]       0    .symtab
  -7.0%     -64  [ = ]       0    ../../src/lib/version/version.c
  +0.3%     +16  [ = ]       0    ../../src/modules/fw_pos_control/FixedwingPositionControl.cpp
  +0.1%     +48  [ = ]       0    [section .symtab]
  +0.3%     +48  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
-0.1%     -72  [ = ]       0    [Unmapped]
+0.0%    +156  +0.0%     +72    TOTAL

Updated: 2025-01-17T19:13:56

@bresch bresch merged commit b1ca049 into main Jan 20, 2025
61 checks passed
@bresch bresch deleted the pr-ekf2_yaw_estimator_validity branch January 20, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants