Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary PR to test workflow changes #44

Closed

Conversation

ItsHarper
Copy link
Contributor

No description provided.

garrettsummerfi3ld and others added 8 commits September 22, 2024 01:48
Updated workflows from upstream main to include macOS, Linux, and ARM variants to build against. Added concurrency for the workflows and also split some workflows out for smaller individual artifact sizes. Updated actions to latest available. Changed build action to run on every commit pushed rather than only PR's and pushes to main.

Updated GoogleTest dependency to resolve issue with the WPILib Artifactory, this was causing issues with builds on macOS where osxuniversal platform type was not available, and split between osxarm64 and osxx86-64.
…latforms

Due to the serial driver, macOS will not compile this project due to lack of linking to IOKit. This is now fixed, but the serial driver is deprecated so this change is largely meaningless.

Disabled reporting warnings as errors to avoid build jobs failing due to warnings.
This caused builds with macOS to fail, however since this is the serial driver, this isn't a meaningful change as its not maintained and slated for removal. This however does clear build failures with macOS.
This check ensures that the tag pushed and the Gradle version are the same, and if the two don't match, then CI will fail.
The serial driver has been stated for removal for some time now, this removed the driver completely.
Dependabot keeps repo dependencies updated. For this configuration, we are just updating GitHub Actions. This can extend into Gradle if needed but this is just to keep individual Actions updated.
@ItsHarper ItsHarper force-pushed the prs-to-unofficial-rev-port/include-static-artifacts branch from 8543331 to ba7d894 Compare November 12, 2024 05:01
@ItsHarper
Copy link
Contributor Author

ItsHarper commented Nov 12, 2024

I didn't double-check every file, but my spot checks look good. Closing in favor of unofficial-rev-port#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants