Include both static and shared WPILib artifacts #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2024
garrettsummerfi3ld
approved these changes
Nov 18, 2024
garrettsummerfi3ld
merged commit 19ab07e
into
unofficial-rev-port:fix/upstream-build-changes
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan is to link
node-can-bridge's dependencies statically in the future (see REVrobotics/node-can-bridge#13). I did at least some spot-checking of the results when run in GitHub Actions here: REVrobotics#44This PR also ports over REVrobotics@44bdc5b, which fixes CI after a recent change to WPILib's Artifactory instance.