Fix app chart linting #2985
Merged
Fix app chart linting #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentsanggds
force-pushed
the
fix-chart-linting
branch
3 times, most recently
from
c734459 to
594b0b9
Compare
kentsanggds
force-pushed
the
fix-chart-linting
branch
from
594b0b9 to
a9c4d81
Compare
kentsanggds
force-pushed
the
fix-chart-linting
branch
from
a9c4d81 to
0af9412
Compare
samsimpson1
reviewed
Feb 7, 2025
kentsanggds
force-pushed
the
fix-chart-linting
branch
from
0af9412 to
e81230a
Compare
|
One other thing: we're also running kubeconform in that pipeline, and it'd be good if the rendered charts were passed to that too |
kentsanggds
force-pushed
the
fix-chart-linting
branch
from
d08c2c5 to
8b7bf2b
Compare
|
I fixed the issue with the chart path, lets get this reviewed again, I'll put the kubeconform check in another PR |
9 tasks
samsimpson1
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix the app chart linting make use of the values file for each environment and run
helm lintagainst it.