Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45156: [Python][Packaging] Refactor Python Windows wheel images to use newer base image #45442

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Feb 6, 2025

Rationale for this change

See #45156.

What changes are included in this PR?

Mostly just stashing my changes here as I work on migrating the existing Dockerfiles to the new base.

Are these changes tested?

TODO

Are there any user-facing changes?

TODO

@github-actions github-actions bot added the awaiting review Awaiting review label Feb 6, 2025
@amoeba
Copy link
Member Author

amoeba commented Feb 7, 2025

This is failing when the image is built with a thrift checksum mismatch from vcpkg but otherwise what's here in the PR is working.

@amoeba
Copy link
Member Author

amoeba commented Feb 7, 2025

I let a build of the base image run overnight and it ran out of disk space on my small hard disk but it looks like it built. So next steps here are:

  • Find a way to get the base image to build
  • Hook it into updated final Dockerfiles and start testing

@amoeba amoeba force-pushed the feature/GH-45156--python-windows-wheel-docker-image branch from 9c311c3 to 0c18bee Compare February 8, 2025 02:14
@amoeba amoeba force-pushed the feature/GH-45156--python-windows-wheel-docker-image branch from 0c18bee to ed31241 Compare February 8, 2025 02:15
@amoeba
Copy link
Member Author

amoeba commented Feb 8, 2025

Good progress today. I was able to build the base image with a combination of increasing the memory limit to 4GB and tweaking the storage limit. I propagated the changes to the other dockerfiles and elsewhere in the repo.

Now this just needs testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant