Add support for building with MinGW #604
Conversation
source/windows/environment.c
Outdated
| #pragma warning(disable : 4996) | ||
| #ifndef __MINGW32__ | ||
| # pragma warning(push) | ||
| # pragma warning(disable : 4996) |
There was a problem hiding this comment.
please comment what warning this disables (and say why if it's not immediately obvious why one would disable it)
For example, this is how we usually disable some MSVC-specific warnings
#if _MSC_VER
# pragma warning(disable : 4221) /* aggregate initializer using local variable addresses */
# pragma warning(disable : 4204) /* non-constant aggregate initializer */
#endif
There was a problem hiding this comment.
This (and the same construct in system_info.c) only looks like it's a newly disabled warning because of indentation changes. It's actually just disabling the MSVC specific #pragma when using MinGW as GCC can't understand MSVC warning codes.
trilader
force-pushed
the
master
branch
2 times, most recently
from
58f298e to
37e5f51
Compare
|
I've rebased to current master in order to trigger the CI again but it looks like it's still not working correctly |
|
Bump. As I mentioned over in aws/aws-sdk-cpp#1426, we are interested in support for the mingw-w64 target (as are others like @nealrichardson). @graebm, I see you are now using github actions: would you accept a PR to add a mingw-w64 target to the build matrix? |
|
FYI, we have adopted a modified version of this patch in msys2 mingw-w64-aws-sdk-cpp. To install binaries from msys2 use pacman -Syu
pacman -S mingw-w64-{i686,x86_64}-aws-sdk-cpp |
Issue #, if available:
Description of changes:
This PR makes it possible to build aws-c-common with the MinGW toolchain on Windows.
The main changes are adding checks for the
__MINGW32__define which is preset on both 32 and 64 bit MinGW installations. Additionally MinGW needs changes related to format strings such as defining__USE_MINGW_ANSI_STDIOand using thegnu_printfattribute.Building with MSVC still works as before these changes. The test pass on both MinGW and MSVC.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.