Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved UI hierarchy #17814

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Resolved UI hierarchy #17814

wants to merge 2 commits into from
+140 −60

Conversation

ickshonpe
Copy link
Contributor

Objective

https://hackmd.io/@dreamertalin/S1AYCTLKJl

Rough sort-of implementation Proposal B

Solution

Testing

Showcase

@ickshonpe
* Added ResolvedChildOf(Entity) and ResolvedChildren(SmallVec<Entity>…
6015a39 
…) components

* Added `Resolve` variant to `UiSystem`
* At the start of PostUpdate in `resolve_ui_hierarchy` system update the ResolvedChildOf and ResolvedChildren with the "unghosted" UI tree (if changed).
* Queries for the ResolvedChildOf and ResolvedChildren in the other UI systems replace UiChildren and UiRootNodes.
@ickshonpe
Fixed imports and layout root nodes query.
549939b
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-UI Graphical user interfaces, styles, layouts, and widgets X-Controversial There is active debate or serious implications around merging this PR S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Feature A new feature, making something new possible S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ickshonpe @alice-i-cecile