Add missing conversion class from vector of WheelTelemetryData to Python list #8560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: glopezdiest <[email protected]>
* Fix OSM2ODR build * Updated fix wheelchair default value
* fixed IMU units * updated autitwheel version
To enable auto-completion and hints in code editors such as VScode, create a `*.pyi` file. This feature is compatible with `python 3.9` and later versions.
Can be None or an Actor
needs merge with dev version
Syntax fix (squased)
FutureActor laod_world_if_different
Was changed to a function in 0.9.15. More info see: carla-simulator#7439
- wrong signatures - wrong names
parameter is called in_point not in_vector
more setters missing, wrong types corrected spelling
The slowdown is considerably more noticeable here since the engine runs much smoother. This makes evident that this is a stopgap measure, and should be looked into further down the line.
…adplugins" (carla-simulator#8167) The downloadplugins target is already defined below (line 162).
Add missing conversion class from vector of WheelTelemetryData to Python list
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
5 tasks
|
The base branch must be ue4-dev for UE4 version and ue5-dev for ue5-dev version. This is warned during opening the PR |
|
I see. I could do another PR monday that forks the ue4 branch. But this small changes is not tied to the UE version. This is simply a change in the PythonAPI interface. Should I do one PR per UE version or this change is going to be ported to the UE5 branch too later? |
|
Do a PR per UE version please. |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing conversion class from vector of WheelTelemetryData to Python list
This adds a missing conversion from vector of WheelTelemetryData to a Python list. When trying to access the "wheels" attribute of the VehicleTelemetryData without this, this exception will occur:
TypError: No to_python (by-value) converter found for C++ type: std::vector<carla::rpc::WheelTelemetryData, std::allocatorcarla::rpc::WheelTelemetryData>
This addition fixes this issue to make the usage in line with similar classes such as "VehiclePhysicsControl" and "WheelPhysicsControl"
Checklist:
devbranch and tested with latest changesmake check(only Linux)Where has this been tested?
This change is