-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload-process uses combined-upload endpoint #551
Open
tony-codecov
wants to merge
16
commits into
main
Choose a base branch
from
tony/single-endpoint-coverage-command
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
❌ 5 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
tony-codecov
changed the title
Single endpoint coverage command initial implementation
Upload-process uses combined-upload endpoint
Nov 8, 2024
Swatinem
previously approved these changes
Nov 11, 2024
Swatinem
previously approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
upload-process
command to use a new combined upload approach that consolidates the create commit, create report, and upload steps into a single network call when possible. This optimization reduces network overhead by combining what were previously three separate API calls into one.combined_upload_logic
function that handles all three steps (create commit, create report, and upload) in one operationupload-process
command to use the combined upload logic by default for coverage reports when not using legacy uploaderFor legacy uploads,
upload-process
still behaves the same as previously.Depends on codecov/codecov-api#962
Closes codecov/engineering-team#2538