Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #10

Closed
wants to merge 3 commits into from
Closed

Fix tests #10

wants to merge 3 commits into from

Conversation

thomas-lebeau
Copy link

First of all, the true and false assertions should be written true() and false(); else all tests will pass even if it should not. The first commit fixes that (and still all tests pass).

The 2 other commits add assertions for the following use cases:

  • ignoring *.swp should ignore files with in subdirectories too
  • ignoring node_modules should no ignore a file names node_modules.json (see Pattern matching is too greedy #9 )

Of course tests are failings now, I'm trying to figure out how to make it work but I may need help with theses regexes.

@phpnode
Copy link
Member

phpnode commented Sep 7, 2015

Hey, thanks for this, btw .true does work without being invoked, I use that all the time.

@thomas-lebeau
Copy link
Author

Not sure if i'm doing wrong but when I do false.should.be.true the test pass; and false.should.be.true() fails as expected

@phpnode
Copy link
Member

phpnode commented Sep 7, 2015

hmm, maybe a problem with the should version?

@thomas-lebeau
Copy link
Author

7.1.0 the last one. They actually changes things in 7.0.0:

Breaking Change No more getter assertions. No all assertions are functions.

Which is a nasty change as the tests will always pass ;)

@phpnode
Copy link
Member

phpnode commented Sep 7, 2015

oh wow that is evil and now I need to go an update a lot of code :(

@alexrqs
Copy link

alexrqs commented Sep 4, 2018

Hi @phpnode, are you accepting this PR anytime soon? it will be beneficial to fix a couple of issues with real tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants