Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, the
true
andfalse
assertions should be writtentrue()
andfalse()
; else all tests will pass even if it should not. The first commit fixes that (and still all tests pass).The 2 other commits add assertions for the following use cases:
*.swp
should ignore files with in subdirectories toonode_modules
should no ignore a file namesnode_modules.json
(see Pattern matching is too greedy #9 )Of course tests are failings now, I'm trying to figure out how to make it work but I may need help with theses regexes.