Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #10

Closed
wants to merge 3 commits into from
Closed

Fix tests #10

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4430870
Fix tests always passing
thomas-lebeau Sep 7, 2015
eeb23b6
*.swp pattern should also apply to all subfolders
thomas-lebeau Sep 7, 2015
f74c300
Add test for issue #9 - pattern matching is too greedy
thomas-lebeau Sep 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 43 additions & 39 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,88 +20,92 @@ describe('gitignore parser', function () {

describe('accepts()', function () {
it('should accept the given filenames', function () {
this.gitignore.accepts('test/index.js').should.be.true;
this.gitignore.accepts('wat/test/index.js').should.be.true;
this.gitignoreNoNegatives.accepts('test/index.js').should.be.true;
this.gitignore.accepts('test/index.js').should.be.true();
this.gitignore.accepts('wat/test/index.js').should.be.true();
this.gitignoreNoNegatives.accepts('test/index.js').should.be.true();
this.gitignoreNoNegatives.accepts('node_modules.json').should.be.true();
});

it('should not accept the given filenames', function () {
this.gitignore.accepts('test.swp').should.be.false;
this.gitignore.accepts('node_modules/wat.js').should.be.false;
this.gitignore.accepts('foo/bar.wat').should.be.false;
this.gitignoreNoNegatives.accepts('node_modules/wat.js').should.be.false;
this.gitignore.accepts('test.swp').should.be.false();
this.gitignore.accepts('foo/test.swp').should.be.false();
this.gitignore.accepts('node_modules/wat.js').should.be.false();
this.gitignore.accepts('foo/bar.wat').should.be.false();
this.gitignoreNoNegatives.accepts('node_modules/wat.js').should.be.false();
});

it('should not accept the given directory', function () {
this.gitignore.accepts('nonexistent').should.be.false;
this.gitignore.accepts('nonexistent/bar').should.be.false;
this.gitignoreNoNegatives.accepts('node_modules').should.be.false;
this.gitignore.accepts('nonexistent').should.be.false();
this.gitignore.accepts('nonexistent/bar').should.be.false();
this.gitignoreNoNegatives.accepts('node_modules').should.be.false();
});

it('should accept unignored files in ignored directories', function () {
this.gitignore.accepts('nonexistent/foo').should.be.true;
this.gitignore.accepts('nonexistent/foo').should.be.true();
});

it('should accept nested unignored files in ignored directories', function () {
this.gitignore.accepts('nonexistent/foo/wat').should.be.true;
this.gitignore.accepts('nonexistent/foo/wat').should.be.true();
});
});

describe('denies()', function () {
it('should deny the given filenames', function () {
this.gitignore.denies('test.swp').should.be.true;
this.gitignore.denies('node_modules/wat.js').should.be.true;
this.gitignore.denies('foo/bar.wat').should.be.true;
this.gitignoreNoNegatives.denies('node_modules/wat.js').should.be.true;
this.gitignore.denies('test.swp').should.be.true();
this.gitignore.denies('foo/test.swp').should.be.true();
this.gitignore.denies('node_modules/wat.js').should.be.true();
this.gitignore.denies('foo/bar.wat').should.be.true();
this.gitignoreNoNegatives.denies('node_modules/wat.js').should.be.true();
});

it('should not deny the given filenames', function () {
this.gitignore.denies('test/index.js').should.be.false;
this.gitignore.denies('wat/test/index.js').should.be.false;
this.gitignoreNoNegatives.denies('test/index.js').should.be.false;
this.gitignoreNoNegatives.denies('wat/test/index.js').should.be.false;
this.gitignore.denies('test/index.js').should.be.false();
this.gitignore.denies('wat/test/index.js').should.be.false();
this.gitignoreNoNegatives.denies('test/index.js').should.be.false();
this.gitignoreNoNegatives.denies('wat/test/index.js').should.be.false();
this.gitignoreNoNegatives.denies('node_modules.json').should.be.false();
});

it('should deny the given directory', function () {
this.gitignore.denies('nonexistent').should.be.true;
this.gitignore.denies('nonexistent/bar').should.be.true;
this.gitignoreNoNegatives.denies('node_modules').should.be.true;
this.gitignoreNoNegatives.denies('node_modules/foo').should.be.true;
this.gitignore.denies('nonexistent').should.be.true();
this.gitignore.denies('nonexistent/bar').should.be.true();
this.gitignoreNoNegatives.denies('node_modules').should.be.true();
this.gitignoreNoNegatives.denies('node_modules/foo').should.be.true();
});

it('should not deny unignored files in ignored directories', function () {
this.gitignore.denies('nonexistent/foo').should.be.false;
this.gitignore.denies('nonexistent/foo').should.be.false();
});

it('should not deny nested unignored files in ignored directories', function () {
this.gitignore.denies('nonexistent/foo/wat').should.be.false;
this.gitignore.denies('nonexistent/foo/wat').should.be.false();
});
});

describe('maybe()', function () {
it('should return true for directories not mentioned by .gitignore', function () {
this.gitignore.maybe('lib').should.be.true;
this.gitignore.maybe('lib/foo/bar').should.be.true;
this.gitignoreNoNegatives.maybe('lib').should.be.true;
this.gitignoreNoNegatives.maybe('lib/foo/bar').should.be.true;
this.gitignore.maybe('lib').should.be.true();
this.gitignore.maybe('lib/foo/bar').should.be.true();
this.gitignoreNoNegatives.maybe('lib').should.be.true();
this.gitignoreNoNegatives.maybe('lib/foo/bar').should.be.true();
});

it('should return false for directories explicitly mentioned by .gitignore', function () {
this.gitignore.maybe('baz').should.be.false;
this.gitignore.maybe('baz/wat/foo').should.be.false;
this.gitignoreNoNegatives.maybe('node_modules').should.be.false;
this.gitignore.maybe('baz').should.be.false();
this.gitignore.maybe('baz/wat/foo').should.be.false();
this.gitignoreNoNegatives.maybe('node_modules').should.be.false();
});

it('should return true for ignored directories that have exceptions', function () {
this.gitignore.maybe('nonexistent').should.be.true;
this.gitignore.maybe('nonexistent/foo').should.be.true;
this.gitignore.maybe('nonexistent/foo/bar').should.be.true;
this.gitignore.maybe('nonexistent').should.be.true();
this.gitignore.maybe('nonexistent/foo').should.be.true();
this.gitignore.maybe('nonexistent/foo/bar').should.be.true();
});

it('should return false for non exceptions of ignored subdirectories', function () {
this.gitignore.maybe('nonexistent/wat').should.be.false;
this.gitignore.maybe('nonexistent/wat/foo').should.be.false;
this.gitignoreNoNegatives.maybe('node_modules/wat/foo').should.be.false;
this.gitignore.maybe('nonexistent/wat').should.be.false();
this.gitignore.maybe('nonexistent/wat/foo').should.be.false();
this.gitignoreNoNegatives.maybe('node_modules/wat/foo').should.be.false();
});
});
});
Expand Down