WIP: Dbex/101195 toggle cleanup (BRD only)

[mchae-nava]

Removal of BRD toggles and Providers used for the EVSS-LH migration. We will maintain the provider pattern for LH for easier migration in the future

This will be one of a handful of PRs to reduce complexity and line count

Summary

• This work is behind a feature toggle (flipper): NO
• (Summarize the changes that have been made to the platform)
  Removal of BRD toggles and EVSS Provider + relevant references
• (If bug, how to reproduce)
• (What is the solution, why is this the solution?)
• (Which team do you work for, does your team own the maintenance of this component?)
• (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

• Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
  [EVSS Migration] Clean up - BRD va.gov-team#102704
• Link to previous change of the code/bug (if applicable)
• Link to epic if not included in ticket

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[github-actions]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: lib/evss/reference_data/service.rb

[github-actions]

1 Warning

⚠️

This PR changes 348 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files .github/CODEOWNERS (+0/-4) app/controllers/v0/disability_compensation_forms_controller.rb (+3/-4) app/controllers/v0/rated_disabilities_discrepancies_controller.rb (+0/-61) config/features.yml (+0/-6) config/routes.rb (+0/-1) lib/disability_compensation/factories/api_provider_factory.rb (+0/-3) lib/disability_compensation/providers/brd/evss_brd_provider.rb (+0/-11) lib/evss/reference_data/service.rb (+0/-30) modules/claims_api/app/controllers/claims_api/v1/forms/disability_compensation_controller.rb (+0/-1) spec/controllers/v0/disability_compensation_forms_controller_spec.rb (+2/-31) spec/controllers/v0/rated_disabilities_discrepancies_controller_spec.rb (+0/-84) spec/lib/disability_compensation/factories/api_provider_factory_spec.rb (+2/-11) spec/lib/disability_compensation/providers/brd/evss_brd_provider_spec.rb (+0/-26) spec/lib/disability_compensation/providers/brd/lighthouse_brd_provider_spec.rb (+0/-4) spec/lib/disability_compensation/providers/brd/lighthouse_staging_brd_provider_spec.rb (+0/-6) spec/lib/evss/reference_data/service_spec.rb (+0/-52) spec/requests/swagger_spec.rb (+2/-4) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger